fix(totp): replace recovery codes keyboard accessibility#692
fix(totp): replace recovery codes keyboard accessibility#692karansapolia wants to merge 1 commit intomozilla:masterfrom
Conversation
| } | ||
|
|
||
| .replace-codes-link { | ||
| .replace-codes-link, button.link:hover { |
There was a problem hiding this comment.
Instead of button.link:hover, lets call it .replace-codes-link:hover and put it in a new line.
vbudhram
left a comment
vbudhram
left a comment
There was a problem hiding this comment.
@karansapolia Just the one thing and this should be good, thanks!
|
Hey @karansapolia, were you still working on this? |
|
Hi @vbudhram, was out of town for a few days. Let me push the changes quick. |
karansapolia
force-pushed
the
fix-598
branch
2 times, most recently
from
8fa6a40 to
ddfb94d
Compare
|
@vladikoff Test failures mention failing to open QR code for pairing, https://circleci.com/gh/mozilla/fxa/6984?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link, did anything change in FF that might break this? |
|
Hey @karansapolia mind rebasing and squashing commits? I believe there are fixes in master that resolves the test failures. |
Make 'Replace recovery codes' keyboard accessible. Replace earlier used link with button element to allow tab indexing and keyboard click events for keyboard accessibility. fixes: mozilla#598
|
@vbudhram all done. |
|
Hey @karansapolia thanks for the pull request! I've cherry-picked your commit to #877, so that it gets signed. Closing here. |
3 participants
Make 'Replace recovery codes' keyboard accessible.
Replace earlier used link with button element to allow
tab indexing and keyboard click events for keyboard
accessibility.
fixes: #598
Continuation of archived repo PR
with all requested changes merged, @vbudhram